ref(integrations): Simplify calling original method in CaptureConsole
#4505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
deleted the
kmclb-integrations-simplify-capture-console-wrapper
branch
AbhiPrasad
added a commit
that referenced
this pull request
Feb 9, 2022
Apply changes from #4505 that applied to `CaptureConsole` integration to the `instrumentConsole` func in `@sentry/utils`. It's important to note that the logic in utils, in `CaptureConsole` and the node `Console` integration is very similar, perhaps we can refactor to combine them.
AbhiPrasad
added a commit
that referenced
this pull request
Feb 9, 2022
Apply changes from #4505 that applied to `CaptureConsole` integration to the `instrumentConsole` func in `@sentry/utils`. It's important to note that the logic in utils, in `CaptureConsole` and the node `Console` integration is very similar, perhaps we can refactor to combine them.
AbhiPrasad
added a commit
that referenced
this pull request
Feb 10, 2022
Apply changes from #4505 that applied to `CaptureConsole` integration to the `instrumentConsole` func in `@sentry/utils`. It's important to note that the logic in utils, in `CaptureConsole` and the node `Console` integration is very similar, perhaps we can refactor to combine them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In responding to #4504, I noticed two things which could be improved about the code in question:
The author of that PR was misled by the admittedly confusing name of the original method we're wrapping.
We've been calling that method in a more complex way than necessary.
This PR fixes both of those problems.
Note: There are no tests for this integration. We should definitely add some, but that is fodder for a separate PR.